Github user colorant commented on the pull request:
https://github.com/apache/spark/pull/1241#issuecomment-47493840
@rxin Moved getBlockLocation method from shuffleBlockManager to
HashShuffleBlockMananger to make the interface more general. Does current
interface looks reasonable for you?
Also still a few shuffle related code could be moved further from block
manager to some specific shuffle manager related classes' implementation ( e.g.
blockManager.getMultiple). But since they are not tightly related to this
shuffleBlockManager generalization works and I am not quite sure whether the
other shufflemanager implementation will reuse them or not, so just leave it as
it is, and could be done in future PR I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
