Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1165#discussion_r14325588
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
    @@ -55,8 +55,7 @@ private class MemoryStore(blockManager: BlockManager, 
maxMemory: Long)
         bytes.rewind()
         if (level.deserialized) {
           val values = blockManager.dataDeserialize(blockId, bytes)
    -      val elements = new ArrayBuffer[Any]
    -      elements ++= values
    +      val elements = values.toArray
    --- End diff --
    
    Good catch. Here we also unroll it entirely in memory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to