GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/8607
[SPARK-10013][ML][JAVA][TEST][WIP] remove java assert from java unit tests
From Jira: We should use assertTrue, etc. instead to make sure the asserts
are not ignored in tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark
SPARK-10013-remove-java-assert-from-java-unit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8607
----
commit 232d70cebcb0fedd44eee6ac4fd0898e1bd502d5
Author: Holden Karau <[email protected]>
Date: 2015-09-03T01:18:34Z
Move JavaLogisticRegressionSuite away from plain-old-asserts to JUnit
assertEquals & assertTrue
commit 3faf3f7f50bb20be89d5458481e10325577102b6
Author: Holden Karau <[email protected]>
Date: 2015-09-03T01:21:52Z
Swap the conditions so that the expected is first and actual is second
matching the jUnit API
commit eaa03d099cabe8da358f6fd68077cb70850c542e
Author: Holden Karau <[email protected]>
Date: 2015-09-04T23:08:44Z
Update more asserts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
