Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7910#discussion_r38634527
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -60,45 +67,55 @@ private[ui] class ExecutorThreadDumpPage(parent:
ExecutorsTab) extends WebUIPage
}
}
}.map { thread =>
- val threadName = thread.threadName
- val className = "accordion-heading " + {
- if (threadName.contains("Executor task launch")) {
- "executor-thread"
- } else {
- "non-executor-thread"
- }
- }
- <div class="accordion-group">
- <div class={className}
onclick="$(this).next().toggleClass('hidden')">
- <a class="accordion-toggle">
- Thread {thread.threadId}: {threadName} ({thread.threadState})
- </a>
- </div>
- <div class="accordion-body hidden">
- <div class="accordion-inner">
- <pre>{thread.stackTrace}</pre>
+ val threadId = thread.threadId
+ <tr class="accordion-heading"
+ onclick={s"toggleThreadStackTrace($threadId)"}
+ onmouseover={s"onMouseOverAndOut($threadId)"}
+ onmouseout={s"onMouseOverAndOut($threadId)"}>
+ <td id={s"${threadId}_td_id"}>{threadId}</td>
+ <td id={s"${threadId}_td_name"}>{thread.threadName}</td>
+ <td id={s"${threadId}_td_state"}>{thread.threadState}</td>
+ <td id={threadId + "_stacktrace"} class="accordion-body hidden">
+ <pre>{thread.stackTrace}</pre>
+ </td>
+ </tr>
+ }
+
+ <div class="row-fluid">
+ <p>Updated at {UIUtils.formatDate(time)}</p>
+ {
+ // scalastyle:off
+ <p><a class="expandbutton"
onClick="expandOrCollapseAllThreadStackTrace(true)">
+ Expand All
+ </a></p>
+ <p><a class="expandbutton hidden"
onClick="expandOrCollapseAllThreadStackTrace(false)">
+ Collapse All
+ </a></p>
+ <div class="form-inline">
+ <div class="bs-example" data-example-id="simple-form-inline">
+ <div class="form-group">
+ <div class="input-group">
+ <input type="text" class="form-control" id="grepexp"></input>
--- End diff --
are we going to implement the grep with ".contains()" instead of regex?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
