Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r37197618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -501,6 +501,10 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case LessThanOrEqual(l, r) => GreaterThan(l, r)
// not(not(e)) => e
case Not(e) => e
+ // De Morgan's law: !(a || b) => !a && !b
--- End diff --
Yeah, I got it. I meant the same thing, for the normal expression
evaluation, this code change probably cause performance regression, it's better
to move the CNF stuff into the `predicates.scala` or `patterns.scala`, which
only works for the predicate push down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
