Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/990#discussion_r13576069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -154,6 +155,10 @@ object NullPropagation extends Rule[LogicalPlan] {
case left :: Literal(null, _) :: Nil => Literal(null, e.dataType)
case _ => e
}
+ case e: CaseConversionExpression => e.children match {
--- End diff --
Yes please.
On Jun 9, 2014 8:16 PM, "Takuya UESHIN" <[email protected]> wrote:
> In
>
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
>
> > @@ -154,6 +155,10 @@ object NullPropagation extends Rule[LogicalPlan] {
> > case left :: Literal(null, _) :: Nil => Literal(null,
e.dataType)
> > case _ => e
> > }
> > + case e: CaseConversionExpression => e.children match {
>
> Fixed the two points.
> Should I remove the mentioned lines?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/990/files#r13576056>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
