Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7458#discussion_r34929647
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -90,7 +90,7 @@ abstract class Expression extends TreeNode[Expression] {
val primitive = ctx.freshName("primitive")
val ve = GeneratedExpressionCode("", isNull, primitive)
ve.code = genCode(ctx, ve)
- ve
--- End diff --
I think it is probably worth it. When codegen bugs pop-up in the real
world this makes it possible to debug, where as otherwise the code is super
hard to follow. I tested on a pretty deeply nested expression and the code
size only went from 25kb to 50kb. I'd imagine the parser is pretty good at
skipping over comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
