Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7435#discussion_r34867911
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/EnsembleTestHelper.scala ---
@@ -70,7 +70,7 @@ object EnsembleTestHelper {
metricName: String = "mse") {
val predictions = input.map(x => model.predict(x.features))
val errors = predictions.zip(input.map(_.label)).map { case
(prediction, label) =>
- prediction - label
+ label - prediction
--- End diff --
Yes, I suggested changing these purely for consistency of the convention.
In several instances it doesn't actually matter to the result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
