Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6294#discussion_r34867762
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -86,20 +97,46 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
"ReceiverTracker", new ReceiverTrackerEndpoint(ssc.env.rpcEnv))
if (!skipReceiverLaunch) receiverExecutor.start()
logInfo("ReceiverTracker started")
+ trackerState = Started
}
}
/** Stop the receiver execution thread. */
def stop(graceful: Boolean): Unit = synchronized {
- if (!receiverInputStreams.isEmpty && endpoint != null) {
+ if (isTrackerStarted) {
// First, stop the receivers
- if (!skipReceiverLaunch) receiverExecutor.stop(graceful)
+ trackerState = Stopping
+ if (!skipReceiverLaunch) {
+ // Send the stop signal to all the receivers
+ endpoint.askWithRetry[Boolean](StopAllReceivers)
+
+ // Wait for the Spark job that runs the receivers to be over
+ // That is, for the receivers to quit gracefully.
+ receiverExecutor.awaitTermination(10000)
+
+ if (graceful) {
+ val pollTime = 100
+ logInfo("Waiting for receiver job to terminate gracefully")
+ while (receiverInfo.nonEmpty || receiverExecutor.running) {
+ Thread.sleep(pollTime)
--- End diff --
This needs to fixed, this could get stuck indefinitely. But different PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
