Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6956#discussion_r33077253
--- Diff: dev/run-tests.py ---
@@ -477,7 +477,15 @@ def determine_java_version(java_exe):
raw_output = subprocess.check_output([java_exe, "-version"],
stderr=subprocess.STDOUT)
- raw_version_str = raw_output.split('\n')[0] # eg 'java version
"1.8.0_25"'
+
--- End diff --
Is it maybe better still to look for the first line starting with "java
version" instead? is that not maybe more explicit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
