LuciferYang commented on code in PR #54651:
URL: https://github.com/apache/spark/pull/54651#discussion_r2894696011
##########
.github/workflows/maven_test.yml:
##########
@@ -205,7 +205,7 @@ jobs:
export TEST_MODULES=`echo "$MODULES_TO_TEST" | sed -e "s%#%/%g"`
./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pkubernetes
-Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pjvm-profiler
-Pspark-ganglia-lgpl -Pkinesis-asl -Djava.version=${JAVA_VERSION/-ea} clean
install
- if [ "$MODULES_TO_TEST" != "connect" ]; then
+ if [ "$MODULES_TO_TEST" != *"hive-thriftserver"* ]; then
Review Comment:
I think we still need to implement more fine-grained control. Some modules
have their test sequences prior to the assembly module, and we should ensure
that these tests can be conducted without relying on assembly. At the least, we
should have a mechanism to inspect, skip, and notify that enabling these tests
requires assembly(such as `assume`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
