dongjoon-hyun commented on code in PR #530:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/530#discussion_r2891582812
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/utils/ReconcilerUtils.java:
##########
@@ -211,6 +221,16 @@ public static <T extends HasMetadata> void
deleteResourceIfExists(
}
}
+ private static boolean isTransientError(KubernetesClientException e) {
+ // code 0 is fabric8's sentinel for network-level failures (timeouts,
connection resets, etc.)
+ int code = e.getCode();
+ return code == 0
+ || code == HTTP_INTERNAL_ERROR
Review Comment:
To be clear, I agree that we need to retry on 500 (Internal Server Error)
error case, but it's not always categorized into a transient error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
