aokolnychyi commented on code in PR #54492:
URL: https://github.com/apache/spark/pull/54492#discussion_r2885460561
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -370,7 +370,16 @@ abstract class Optimizer(catalogManager: CatalogManager)
s.withNewPlan(removeTopLevelSort(newPlan))
}
- def apply(plan: LogicalPlan): LogicalPlan =
plan.transformAllExpressionsWithPruning(
+ // optimizes subquery expressions, ignoring row-level operation conditions
+ def apply(plan: LogicalPlan): LogicalPlan = {
Review Comment:
@szehon-ho @gengliangwang, could you double check this?
The new logic uses:
- `transformWithPruning` to traverse plans
- `transformExpressionsWithPrunning` to traverse expressions in each node
Instead of `transformAllExpressionsWithPruning` before.
This should be equivalent but another pair of eyes would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
