cloud-fan commented on code in PR #54459: URL: https://github.com/apache/spark/pull/54459#discussion_r2885038336
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/PartitionPredicateImpl.scala: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.internal.connector + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.connector.expressions.filter.PartitionPredicate + +/** + * An implementation for [[PartitionPredicate]] that wraps a Catalyst Expression representing a + * partition filter. + * <p> + * Supporting data sources receive these via + * [[org.apache.spark.sql.connector.read.SupportsPushDownV2Filters#pushPredicates pushPredicates]] + * and may use them for additional partition filtering. + */ +class PartitionPredicateImpl( + private val catalystExpression: Expression, + private val partitionSchema: Seq[AttributeReference]) + extends PartitionPredicate( + PartitionPredicate.NAME, + org.apache.spark.sql.connector.expressions.Expression.EMPTY_EXPRESSION) with Logging { Review Comment: **Broken `equals`/`hashCode`: all `PartitionPredicateImpl` instances are considered equal.** `GeneralScalarExpression.equals()` compares `name` and `children`. Every `PartitionPredicateImpl` has name `"PartitionPredicate"` and children `EMPTY_EXPRESSION`, so two completely different predicates (e.g. `part_col LIKE 'b%'` and `part_col IS NOT NULL`) are considered equal and have the same hash code. This means: - If they end up in a `Set`, predicates silently collapse. - `PushedDownOperators` is a case class whose `equals` compares `pushedPredicates` element-wise — two plans with different partition predicates could be considered equal. `PartitionPredicateImpl` should override `equals`/`hashCode` to incorporate `catalystExpression`, e.g.: ```scala override def equals(other: Any): Boolean = other match { case o: PartitionPredicateImpl => catalystExpression.semanticEquals(o.catalystExpression) case _ => false } override def hashCode(): Int = catalystExpression.semanticHash() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
