uros-db commented on code in PR #54571: URL: https://github.com/apache/spark/pull/54571#discussion_r2884645765
########## dev/generate_srs_registry.py: ########## @@ -0,0 +1,377 @@ +#!/usr/bin/env python3 Review Comment: There is no consistent convention, some use hyphens (e.g. check-protos.py) and others use underscores (e.g. check_pyspark_custom_errors.py). I think either is fine, but I would slightly prefer underscores for Python because hyphenated filenames can't be imported as Python modules (not needed now because script runs standalone, but may come in handy sometime in the future). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
