cloud-fan commented on code in PR #54521:
URL: https://github.com/apache/spark/pull/54521#discussion_r2883665604


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########


Review Comment:
   This deprecation message is simply wrong, as these two configs have 
different behaviors and we have to use `CONVERT_CTAS` in our workloads to 
retain legacy behaviors.
   
   To be more concrete, `CONVERT_CTAS` only affects CTAS to create data source 
table instead of Hive tables, while `LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT` 
affects all the table creation cases.
   
   To keep the legacy behavior that only allow CTAS to convert Hive tables to 
data source tables, `CONVERT_CTAS` is the only option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to