dongjoon-hyun commented on code in PR #532: URL: https://github.com/apache/spark-kubernetes-operator/pull/532#discussion_r2875992216
########## docs/config_properties.md: ########## @@ -6,6 +6,7 @@ | spark.kubernetes.operator.api.retryMaxAttempts | Integer | 15 | false | Max attempts of retries on unhandled controller errors. Setting this to non-positive value means no retry. | | spark.kubernetes.operator.api.secondaryResourceCreateMaxAttempts | Long | 3 | false | Maximal number of retry attempts of requesting secondary resource for Spark application. This would be performed on top of k8s client spark.kubernetes.operator.retry.maxAttempts to overcome potential conflicting reconcile on the same SparkApplication. This should be positive number | | spark.kubernetes.operator.api.statusPatchMaxAttempts | Long | 3 | false | Maximal number of retry attempts of requests to k8s server for resource status update. This would be performed on top of k8s client spark.kubernetes.operator.retry.maxAttempts to overcome potential conflicting update on the same SparkApplication. This should be positive number. | + | spark.kubernetes.operator.cacheSyncTimeoutSeconds | Integer | 30 | false | Timeout threshold for operator to sync informer cache in seconds. | Review Comment: Just a question. Can we start to group the set of informer-related configurations for the future? We already have one. https://github.com/apache/spark-kubernetes-operator/blob/beab9390c48a614bb2cdd1e8d1b235519bd2237a/spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java#L101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
