LuciferYang commented on code in PR #54570: URL: https://github.com/apache/spark/pull/54570#discussion_r2872217032
########## core/src/test/java/org/apache/spark/unsafe/PlatformBenchmarkTestUtils.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.unsafe; + +public class PlatformBenchmarkTestUtils { + + /** + * Copies memory from the source (either on-heap or off-heap) to the destination integer array + * using a manual loop. This method mimics the implementation of manual memory copying found + * in {@link org.apache.spark.sql.execution.vectorized.OnHeapColumnVector}. + * + * @param src The source object (null for off-heap memory). + * @param srcOffset The initial offset in the source memory. + * @param dst The destination integer array. + * @param count The number of integers to copy. + */ + public static void copyToIntArrayManual(Object src, long srcOffset, int[] dst, int count) { Review Comment: This portion of code needs to be extracted into Java in order to simulate performance similar to the loop-based assignment in OnHeapColumnVector. If placed in Scala code, it will become slower, even when using a while loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
