davidm-db commented on code in PR #54223:
URL: https://github.com/apache/spark/pull/54223#discussion_r2871923190
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala:
##########
@@ -70,62 +71,63 @@ object RowEncoder extends DataTypeErrorsBase {
}
private[sql] def encoderForDataType(dataType: DataType, lenient: Boolean):
AgnosticEncoder[_] =
Review Comment:
done
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/EncoderUtils.scala:
##########
@@ -98,19 +99,21 @@ object EncoderUtils {
}
def dataTypeJavaClass(dt: DataType): Class[_] = {
- dt match {
- case _: DecimalType => classOf[Decimal]
- case _: DayTimeIntervalType => classOf[PhysicalLongType.InternalType]
- case _: YearMonthIntervalType =>
classOf[PhysicalIntegerType.InternalType]
- case _: TimeType => classOf[PhysicalLongType.InternalType]
- case _: StringType => classOf[UTF8String]
- case _: StructType => classOf[InternalRow]
- case _: ArrayType => classOf[ArrayData]
- case _: MapType => classOf[MapData]
- case _: GeographyType => classOf[GeographyVal]
- case _: GeometryType => classOf[GeometryVal]
- case ObjectType(cls) => cls
- case _ => typeJavaMapping.getOrElse(dt, classOf[java.lang.Object])
+ TypeOps(dt).map(_.getJavaClass).getOrElse {
Review Comment:
done
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1989,30 +1990,32 @@ object CodeGenerator extends Logging {
}
}
- @tailrec
- def javaClass(dt: DataType): Class[_] = dt match {
- case BooleanType => java.lang.Boolean.TYPE
- case ByteType => java.lang.Byte.TYPE
- case ShortType => java.lang.Short.TYPE
- case IntegerType | DateType | _: YearMonthIntervalType =>
java.lang.Integer.TYPE
- case LongType | TimestampType | TimestampNTZType | _: DayTimeIntervalType
| _: TimeType =>
- java.lang.Long.TYPE
- case FloatType => java.lang.Float.TYPE
- case DoubleType => java.lang.Double.TYPE
- case _: DecimalType => classOf[Decimal]
- case BinaryType => classOf[Array[Byte]]
- case _: GeographyType => classOf[GeographyVal]
- case _: GeometryType => classOf[GeometryVal]
- case _: StringType => classOf[UTF8String]
- case CalendarIntervalType => classOf[CalendarInterval]
- case _: StructType => classOf[InternalRow]
- case _: ArrayType => classOf[ArrayData]
- case _: MapType => classOf[MapData]
- case udt: UserDefinedType[_] => javaClass(udt.sqlType)
- case ObjectType(cls) => cls
- case VariantType => classOf[VariantVal]
- case _ => classOf[Object]
- }
+ def javaClass(dt: DataType): Class[_] =
+ TypeOps(dt).map(_.getJavaClass).getOrElse {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
