caldempsey commented on PR #152: URL: https://github.com/apache/spark-connect-go/pull/152#issuecomment-3980541133
Updated the PR addressing feedback. Removed NewRowPull2 entirely and consolidated it into NewRowSequence. Fixed the c.done race condition by having ToRecordSequence track 1-1 against ToTable. Kept things WET intentionally for now to avoid a negative diff against ToTable, will DRY up in a follow-up. Other comments addressed. Marking as ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
