pan3793 commented on code in PR #54467:
URL: https://github.com/apache/spark/pull/54467#discussion_r2853710306
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -146,7 +146,9 @@ case class CatalogStorageFormat(
outputFormat: Option[String],
serde: Option[String],
compressed: Boolean,
- properties: Map[String, String]) extends MetadataMapSupport {
+ properties: Map[String, String],
+ serdeName: Option[String] = None)
+ extends MetadataMapSupport {
Review Comment:
How many places would it have impacted if you put `serdeName` before
`serde`, without a default `None`?
and please keep the original style of `extends MetadataMapSupport`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
