cloud-fan commented on code in PR #54223:
URL: https://github.com/apache/spark/pull/54223#discussion_r2852025929
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala:
##########
@@ -71,6 +72,9 @@ object RowEncoder extends DataTypeErrorsBase {
private[sql] def encoderForDataType(dataType: DataType, lenient: Boolean):
AgnosticEncoder[_] =
dataType match {
+ // Types Framework: delegate to EncodeTypeOps for supported types when
enabled
+ case _ if SqlApiConf.get.typesFrameworkEnabled &&
EncodeTypeOps.supports(dataType) =>
Review Comment:
shall we check the conf in the narrow wrist `TypeApiOps.apply`, instead of
caller sides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
