HeartSaVioR commented on code in PR #53930:
URL: https://github.com/apache/spark/pull/53930#discussion_r2850163172
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/join/SymmetricHashJoinStateManager.scala:
##########
@@ -512,8 +512,11 @@ class SymmetricHashJoinStateManagerV4(
key: UnsafeRow,
timestamp: Long,
valuesWithMatched: Seq[(UnsafeRow, Boolean)]): Unit = {
+ // copy() is required because convertToValueRow reuses its internal
UnsafeProjection output
+ // TODO: StateStore.putList should allow iterator to be passed in, so
that we don't need to
Review Comment:
@anishshri-db
This shows the necessity of introducing another API on StateStore. I'll file
a TODO JIRA ticket if you agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
