yyanyy commented on code in PR #54454:
URL: https://github.com/apache/spark/pull/54454#discussion_r2850043432
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ConstraintParseSuiteBase.scala:
##########
@@ -92,4 +93,36 @@ abstract class ConstraintParseSuiteBase extends AnalysisTest
with SharedSparkSes
columns = columns, tableConstraints = constraints, isCreateTable =
isCreateTable)
comparePlans(parsed, expected)
}
+
+ test("CTAS with constraints is not allowed") {
Review Comment:
sounds good; an alternative would be to parameterized the constraint
definition string per subclass extending this base class and keep tests here,
but indeed it will still result in many more test runs and feels unnecessarily
complex for a simple change like this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
