peter-toth commented on code in PR #54330:
URL: https://github.com/apache/spark/pull/54330#discussion_r2848638465
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -41,17 +39,16 @@ case class BatchScanExec(
runtimeFilters: Seq[Expression],
ordering: Option[Seq[SortOrder]] = None,
@transient table: Table,
- spjParams: StoragePartitionJoinParams = StoragePartitionJoinParams()
- ) extends DataSourceV2ScanExecBase with
KeyGroupedPartitionedScan[InputPartition] {
+ keyGroupedPartitioning: Option[Seq[Expression]] = None
+ ) extends DataSourceV2ScanExecBase {
@transient lazy val batch: Batch = if (scan == null) null else scan.toBatch
// TODO: unify the equal/hashCode implementation for all data source v2
query plans.
override def equals(other: Any): Boolean = other match {
case other: BatchScanExec =>
this.batch != null && this.batch == other.batch &&
- this.runtimeFilters == other.runtimeFilters &&
- this.spjParams == other.spjParams
Review Comment:
Yes, you are right `keyGroupedPartitioning` must remain in this comparison.
Fixed in
https://github.com/apache/spark/pull/54330/commits/48735135a255720e7a14403f0167c2743dd37cd9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
