jonmio commented on PR #54429: URL: https://github.com/apache/spark/pull/54429#issuecomment-3953037351
> This is not minor, changing the core constructor path needs a JIRA at least and some testing. @holdenk I created a JIRA ticket and linked it to this PR. Also added a test verifying the change made here. While this does change the core `create` codepath it is only modifying a [very recently added branch for PySpark classic](https://github.com/apache/spark/pull/53820). This was added around 6 weeks ago. > I don't see a benefit to this change. The main benefits here are minimizing divergence with the `getOrCreate` codepath and removing the unnecessary `SparkConf` creation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
