holdenk commented on PR #51948: URL: https://github.com/apache/spark/pull/51948#issuecomment-3947145908
> For implementation, I think this PR modifies the right place - Given that Spark supports `ResourceProfile`, which means that executor cores might be variant in a single app, we can NOT apply `ActiveProcessorCount` for executor like `SparkContext.supplementJavaModuleOptions|supplementJavaIPv6Options`, instead, we should apply the `ActiveProcessorCount` on assembling the command for driver/executor bootstrap, where we know the cores/memory exactly. So it pulls the cores from whats passed into the executor runnable which I think is the right place (and the constructor varies on resource profile id) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
