szehon-ho commented on code in PR #54411:
URL: https://github.com/apache/spark/pull/54411#discussion_r2842919733


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSessionCatalogSuite.scala:
##########
@@ -108,6 +108,19 @@ class InMemoryTableSessionCatalog extends 
TestV2SessionCatalogBase[InMemoryTable
   }
 
   override def loadTable(ident: Identifier): Table = {
+    // Check for metadata table pattern: namespace = [db, tableName], name = 
"snapshots"
+    // This simulates how Iceberg handles metadata tables like 
db.table.snapshots
+    if (ident.name() == "snapshots" && ident.namespace().length >= 1) {

Review Comment:
   done.  In Iceberg, it catch the Iceberg NoSuchTableException.  
   
   one small difference, our test V2SessionCatalog is not as strong , so I end 
up catching AnalysisException, else we have to implement all the wrappers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to