dongjoon-hyun commented on code in PR #513:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/513#discussion_r2838688578
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ApplicationStateSummary.java:
##########
@@ -57,6 +57,12 @@ public enum ApplicationStateSummary implements
BaseStateSummary {
*/
RunningHealthy,
+ /**
+ * Application is running with dynamic allocation disabled and executor
count is between minimum
+ * and maximum thresholds. The application is in a tolerable state but not
at optimal capacity.
Review Comment:
This is correct mathematically but wrong in the general English sentence.
Could you revise like the following, @jiangzho ?
```
- between minimum and maximum thresholds
+ between minimum and maximum thresholds, exclusive
```
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/Constants.java:
##########
@@ -164,6 +164,13 @@ public class Constants {
/** Message indicating that the application is running healthy. */
public static final String RUNNING_HEALTHY_MESSAGE = "Application is running
healthy.";
+ /**
+ * Message indicating that the application is running with partial executor
capacity (between min
+ * and max with dynamic allocation disabled).
Review Comment:
ditto.
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/Constants.java:
##########
@@ -164,6 +164,13 @@ public class Constants {
/** Message indicating that the application is running healthy. */
public static final String RUNNING_HEALTHY_MESSAGE = "Application is running
healthy.";
+ /**
+ * Message indicating that the application is running with partial executor
capacity (between min
+ * and max with dynamic allocation disabled).
+ */
+ public static final String RUNNING_WITH_PARTIAL_CAPACITY_MESSAGE =
+ "Application is running with executor count between minimum and maximum
capacity.";
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
