juliuszsompolski commented on code in PR #54279:
URL: https://github.com/apache/spark/pull/54279#discussion_r2830065788
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -1276,7 +1276,7 @@ def close(self) -> None:
"""
Close the channel.
"""
- concurrent.futures.wait(self._release_futures)
+ concurrent.futures.wait(self._release_futures, timeout=10)
Review Comment:
Yes, the server needs to be prepared for any behavior of the client anyway,
including the client disappearing at any moment, without releases etc. so it's
fine for the client to also not block indefinitely and hang but timeout here.
Not sure if we need any smarter timeout. Are other timeouts (like e.g. retry)
hardcoded as well, or configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
