HyukjinKwon commented on code in PR #54118:
URL: https://github.com/apache/spark/pull/54118#discussion_r2766523584
##########
sql/core/src/main/scala/org/apache/spark/sql/artifact/ArtifactManager.scala:
##########
@@ -194,6 +194,17 @@ class ArtifactManager(session: SparkSession) extends
AutoCloseable with Logging
// (e.g., after clone), we should replace it.
val existingBlock = hashToCachedIdMap.get(hash)
if (existingBlock == null || existingBlock.id != blockId) {
+ val storageLevelStr = session.conf.get(
+ SQLConf.ARTIFACT_MANAGER_CACHE_STORAGE_LEVEL)
+ val storageLevel = try {
Review Comment:
Seems like you're not setting `storageLevel` to `level`. BTW, I think you
don't need to do a try-catch. You can add the validation logic in conf itself
with checkValues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
