pan3793 commented on code in PR #53608:
URL: https://github.com/apache/spark/pull/53608#discussion_r2646831674
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -271,7 +271,9 @@ private[hive] class HiveClientImpl(
/**
* Runs `f` with ThreadLocal session state and classloaders configured for
this version of hive.
*/
- def withHiveState[A](f: => A): A = retryLocked {
+ def withHiveState[A](f: => A): A = withHiveState[A](Map.empty[String,
String])(f)
+
+ def withHiveState[A](confOverlay: Map[String, String])(f: => A): A =
retryLocked {
Review Comment:
I think it's safe to modify some configs, as `retryLocked` holds a lock of
the `clientLoader: IsolatedClientLoader` internally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
