cloud-fan commented on code in PR #52968:
URL: https://github.com/apache/spark/pull/52968#discussion_r2566971586
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala:
##########
@@ -308,6 +308,27 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
}
}
+ test("SortAggregate metrics") {
+ // Force use SortAggregateExec instead of HashAggregateExec
+ withSQLConf("spark.sql.test.forceApplySortAggregate" -> "true",
+ SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false") {
Review Comment:
nit: other tests in this suite do not turn off whole stage codegen, why it's
necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
