zhztheplayer commented on code in PR #53128:
URL: https://github.com/apache/spark/pull/53128#discussion_r2541319769
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -372,18 +372,16 @@ case class EnsureRequirements(
*/
private def reorderJoinPredicates(plan: SparkPlan): SparkPlan = {
plan match {
- case ShuffledHashJoinExec(
- leftKeys, rightKeys, joinType, buildSide, condition, left, right,
isSkew) =>
+ case shj @ ShuffledHashJoinExec(
+ leftKeys, rightKeys, _, _, _, left, right, _) =>
val (reorderedLeftKeys, reorderedRightKeys) =
reorderJoinKeys(leftKeys, rightKeys, left.outputPartitioning,
right.outputPartitioning)
- ShuffledHashJoinExec(reorderedLeftKeys, reorderedRightKeys, joinType,
buildSide, condition,
- left, right, isSkew)
+ shj.copy(leftKeys = reorderedLeftKeys, rightKeys = reorderedRightKeys)
Review Comment:
I am curious how does this change work? I think Scala `copy` shouldn't
preserve tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
