szehon-ho commented on code in PR #52599:
URL: https://github.com/apache/spark/pull/52599#discussion_r2453588668
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala:
##########
@@ -151,7 +158,12 @@ case class DataSourceV2ScanRelation(
override def name: String = relation.name
override def simpleString(maxFields: Int): String = {
- s"RelationV2${truncatedString(output, "[", ", ", "]", maxFields)} $name"
+ val outputString = truncatedString(output, "[", ", ", "]", maxFields)
+ val nameWithTimeTravelSpec = relation.timeTravelSpec match {
Review Comment:
same comment
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala:
##########
@@ -65,7 +66,12 @@ abstract class DataSourceV2RelationBase(
override def skipSchemaResolution: Boolean =
table.supports(TableCapability.ACCEPT_ANY_SCHEMA)
override def simpleString(maxFields: Int): String = {
- s"RelationV2${truncatedString(output, "[", ", ", "]", maxFields)} $name"
+ val outputString = truncatedString(output, "[", ", ", "]", maxFields)
+ val nameWithTimeTravelSpec = timeTravelSpec match {
Review Comment:
nit: seems clearer to have this just return either $spec or empty, and have
the final string be
"RelationV2$outputString $timeTravelSpec $name"
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -59,6 +66,11 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
setupTestData()
+ override def beforeEach(): Unit = {
Review Comment:
can we override sparkConf? It makes it easier to see what is overriden and
to override things later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
