cloud-fan commented on code in PR #52638:
URL: https://github.com/apache/spark/pull/52638#discussion_r2444066201
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -602,14 +602,25 @@ propertyList
;
property
- : key=propertyKey (EQ? value=propertyValue)?
+ : key=propertyKeyOrStringLit EQ value=propertyValue
#propertyWithKeyAndEquals
+ | key=propertyKeyNoCoalesce value=propertyValue?
#propertyWithStringKeyNoEquals
+ | key=propertyKey (EQ? value=propertyValue)?
#propertyWithIdentifierKey
Review Comment:
hmm do we still need this rule? I think the above two covers all the
supported cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]