viirya commented on code in PR #8:
URL: https://github.com/apache/spark-connect-rust/pull/8#discussion_r2392130583
##########
crates/connect/src/functions/mod.rs:
##########
@@ -1108,7 +1108,19 @@ gen_func!(stddev, [col: Column], "Alias for
stddev_samp.");
gen_func!(stddev_pop, [col: Column], "Returns population standard deviation of
the expression in a group.");
gen_func!(stddev_samp, [col: Column], "Returns the unbiased sample standard
deviation of the expression in a group.");
gen_func!(sum, [col: Column], "Returns the sum of all values in the
expression.");
-gen_func!(sum_distinct, [col: Column], "Returns the sum of distinct values in
the expression.");
+/// "Returns the sum of distinct values in the expression."
+pub fn sum_distinct(col: impl Into<Column>) -> Column {
Review Comment:
I wonder why the args are not the same as `count_distinct`?
rust
```rust
pub fn count_distinct<I>(col: impl Into<Column>, cols: Option<I>) -> Column
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
