cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2429626986
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2200,7 +2205,15 @@ class AstBuilder extends DataTypeAstBuilder
Limit(expression(ctx.expression), query)
case ctx: SampleByPercentileContext =>
- val fraction = ctx.percentage.getText.toDouble
+ val fraction = if (ctx.DECIMAL_VALUE() != null) {
ctx.DECIMAL_VALUE().getText.toDouble }
+ else {
+ // Assert that parameter markers have been substituted before
reaching AstBuilder
+ assert(ctx.integerValue().getChild(0).getClass.getSimpleName !=
Review Comment:
we probably should add a method to get integer value after parameter
replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
