pan3793 commented on code in PR #52584:
URL: https://github.com/apache/spark/pull/52584#discussion_r2426250281
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/V1Writes.scala:
##########
@@ -199,15 +205,18 @@ object V1WritesUtils {
expressions.exists(_.exists(_.isInstanceOf[Empty2Null]))
}
+ def eliminateFoldableOrdering(ordering: Seq[SortOrder], query: LogicalPlan):
LogicalPlan =
+ EliminateSorts(FoldablePropagation(Sort(ordering, global = false, query)))
+
def isOrderingMatched(
- requiredOrdering: Seq[Expression],
+ requiredOrdering: Seq[SortOrder],
Review Comment:
Reverted it back, and added comments to mention it intends to ignore
SortDirection and NullOrdering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
