karuppayya commented on code in PR #52460:
URL: https://github.com/apache/spark/pull/52460#discussion_r2399882558
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala:
##########
@@ -231,6 +231,10 @@ case class StreamingDataSourceV2ScanRelation(
override protected def stringArgs: Iterator[Any] = stringArgsVal.iterator
}
+object DataSourceV2Table {
Review Comment:
nit: Since it extracts v2 table from the relation, i would prefer it to be
`ExtractV2Table`, which makes it explict that it is just an extractor and not a
top level class (like `org.apache.spark.sql.catalog.Table`), and follows other
clases like `ExtractEquiJoinKeys `, `ExtractJoinWithBuckets ` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
