zhengruifeng commented on code in PR #52464:
URL: https://github.com/apache/spark/pull/52464#discussion_r2381079343
##########
python/pyspark/sql/connect/window.py:
##########
@@ -69,6 +69,9 @@ def __new__(
self.__init__(partitionSpec, orderSpec, frame) # type: ignore[misc]
return self
+ def __getnewargs__(self):
Review Comment:
we have defined the `__new__` for this class,
without the `__getnewargs__`, pickle won't `dumps` the necessary arguments
which is needed in `loads`
referring to
https://docs.python.org/3/library/pickle.html#pickling-class-instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
