cloud-fan commented on code in PR #52443:
URL: https://github.com/apache/spark/pull/52443#discussion_r2378364931
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -179,8 +179,14 @@ case class EnsureRequirements(
newChildren.isDefined
}
+ val isShufflePassThroughCompatible = !isKeyGroupCompatible &&
Review Comment:
shall we combine this with the key group compatibility check?
```
// Check if the following conditions are satisfied:
// 1. There are exactly two children (e.g., join). Note that Spark
doesn't support
// multi-way join at the moment, so this check should be
sufficient.
// 2. All children are of the same partitioning, and they are
compatible with each other
// If both are true, skip shuffle.
val areChildrenCompatible = parent.isDefined &&
children.length == 2 && childrenIndexes.length == 2 && {
key group check and id pass through check
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
