ivoson commented on code in PR #52336:
URL: https://github.com/apache/spark/pull/52336#discussion_r2371326830
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -1679,6 +1679,15 @@ package object config {
.checkValues(Set("ADLER32", "CRC32", "CRC32C"))
.createWithDefault("ADLER32")
+ private[spark] val SCHEDULER_CHECKSUM_MISMATCH_FULL_RETRY_ENABLED =
+ ConfigBuilder("spark.scheduler.checksumMismatchFullRetry.enabled")
+ .doc("Whether to retry all tasks of a consumer stage when we detect
checksum mismatches " +
+ "with its producer stages. The checksum computation is controlled by
another config " +
+ "called SHUFFLE_ORDER_INDEPENDENT_CHECKSUM_ENABLED.")
Review Comment:
Yes, there is log written when checksum mismatch happens. If
`SCHEDULER_CHECKSUM_MISMATCH_FULL_RETRY_ENABLED` is false, there'll be no fully
retry for succeeding stages but only logs for the checksum mismatch.
And when we want to enable `SCHEDULER_CHECKSUM_MISMATCH_FULL_RETRY_ENABLED`,
need to make sure `SHUFFLE_ORDER_INDEPENDENT_CHECKSUM_ENABLED` is also true if
we keep these two configs.
One config can be easier to use. If it makes sense to you all, I'll remove
`SHUFFLE_ORDER_INDEPENDENT_CHECKSUM_ENABLED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
