sryza commented on code in PR #52101:
URL: https://github.com/apache/spark/pull/52101#discussion_r2372807990
##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -327,7 +355,7 @@ This is a streaming data writer that write the metadata
information of each micr
cnt += 1
return SimpleCommitMessage(partition_id=partition_id, count=cnt)
- def commit(self, messages, batchId) -> None:
+ def commit(self, messages: List[Optional[WriterCommitMessage]],
batchId: int) -> None:
Review Comment:
👍
##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -336,7 +364,7 @@ This is a streaming data writer that write the metadata
information of each micr
with open(os.path.join(self.path, f"{batchId}.json"), "a") as file:
file.write(json.dumps(status) + "\n")
- def abort(self, messages, batchId) -> None:
+ def abort(self, messages: List[Optional[WriterCommitMessage]], batchId:
int) -> None:
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
