szehon-ho commented on code in PR #52359: URL: https://github.com/apache/spark/pull/52359#discussion_r2353590602
########## sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala: ########## @@ -2572,7 +2572,8 @@ abstract class MergeIntoTableSuiteBase extends RowLevelOperationSuiteBase } } - // TODO- support schema evolution for missing nested types using UPDATE SET * and INSERT * + // currently the source struct needs to be fully compatible with target struct Review Comment: Note: this is unrelated, but not sure we are going to do the TODO. It can be addressed it in https://github.com/apache/spark/pull/52347, but still debating whether it makes sense to do or not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org