cookiedough77 commented on code in PR #52328:
URL: https://github.com/apache/spark/pull/52328#discussion_r2353449225
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/pipelines/PipelinesHandler.scala:
##########
@@ -210,18 +236,40 @@ private[connect] object PipelinesHandler extends Logging {
Map("flowName" -> flow.getFlowName))
}
+ var destinationIdentifier = GraphIdentifierManager
+ .parseTableIdentifier(name = flow.getTargetDatasetName, spark =
sessionHolder.session)
+ val flowWritesToView =
+ graphElementRegistry.getViews()
+ .filter(_.isInstanceOf[TemporaryView])
+ .exists(_.identifier == destinationIdentifier)
+
+ // If the flow is created implicitly as part of defining a view, then we
do not
+ // qualify the flow identifier and the flow destination. This is because
views are
+ // not permitted to have multipart
+ if (!isImplicitFlow || !flowWritesToView) {
Review Comment:
hi, if we use this, rawFlowIdentifier, rawDestinationIdentifier is inferred
as type java.io.Serializable because two branches have incompatible types. (if
(isImplicitFlowForTempView) => TableIdentifier, else =>
InternalDatasetIdentifier). I'm thinking of a better way to resolve this...
oh I take it back. figured it out now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
