mkaravel commented on code in PR #52316:
URL: https://github.com/apache/spark/pull/52316#discussion_r2345992596
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -130,6 +130,11 @@ case class HllSketchAgg(
* Evaluate the input row and update the HllSketch instance with the row's
value. The update
* function only supports a subset of Spark SQL types, and an exception will
be thrown for
* unsupported types.
+ * Notes:
+ * - Null values are ignored.
+ * - Empty values are also ignored:
+ * * Empty strings
+ * * Empty byte arrays
Review Comment:
```suggestion
* Notes:
* - Null values are ignored.
* - Empty byte arrays are ignored.
* - Strings that are collation-equal to the empty string are ignored.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
