cloud-fan commented on code in PR #52173:
URL: https://github.com/apache/spark/pull/52173#discussion_r2338855629
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/parameters.scala:
##########
@@ -104,6 +104,28 @@ case class PosParameterizedQuery(child: LogicalPlan, args:
Seq[Expression])
copy(child = newChild)
}
+/**
+ * The logical plan representing a parameterized query with general parameter
support.
+ * This allows the query to use either positional or named parameters based on
the
+ * parameter markers found in the query, with optional parameter names
provided.
+ *
+ * @param child The parameterized logical plan.
+ * @param args The literal values or collection constructor functions such as
`map()`,
+ * `array()`, `struct()` of parameters.
+ * @param paramNames Optional parameter names corresponding to args. If
provided for an argument,
+ * that argument can be used for named parameter binding. If
not provided
+ * parameters are treated as positional.
+ */
+case class GeneralParameterizedQuery(
+ child: LogicalPlan,
+ args: Seq[Expression],
+ paramNames: Seq[String])
Review Comment:
so this is either empty, or the same length as `args`? can we add an assert
to guarantee it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
