beliefer commented on code in PR #52257:
URL: https://github.com/apache/spark/pull/52257#discussion_r2329464704


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/SupportsPushDownCatalystFilters.scala:
##########
@@ -18,14 +18,15 @@ package org.apache.spark.sql.internal.connector
 
 import org.apache.spark.sql.catalyst.expressions.Expression
 import org.apache.spark.sql.connector.expressions.filter.Predicate
+import org.apache.spark.sql.connector.read.ScanBuilder
 
 /**
- * A mix-in interface for {@link FileScanBuilder}. File sources can implement 
this interface to

Review Comment:
   I'm not sure. It seems @huaxingao designed it for some reason.
   Apart from this concern, this change looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to