cloud-fan commented on code in PR #52190:
URL: https://github.com/apache/spark/pull/52190#discussion_r2314344281
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowWindowPythonEvaluatorFactory.scala:
##########
@@ -149,7 +149,7 @@ class ArrowWindowPythonEvaluatorFactory(
private val inMemoryThreshold = conf.windowExecBufferInMemoryThreshold
private val spillThreshold = conf.windowExecBufferSpillThreshold
- private val spillSizeThreshold = conf.windowExecBufferSpillSizeThreshold
+ private val sizeInBytesSpillThreshold =
conf.windowExecBufferSpillSizeThreshold
Review Comment:
For now I reuse the spill threshold config for the
`ExternalAppendOnlyUnsafeRowArray` in-memory buffer threshold as well. We can
add new configs if we want (but it will be a lot of configs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
